Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Card): icon prop #6683

Merged
merged 1 commit into from
Jul 29, 2024
Merged

feat(Card): icon prop #6683

merged 1 commit into from
Jul 29, 2024

Conversation

guoyunhe
Copy link
Contributor

@guoyunhe guoyunhe commented Jul 29, 2024

  • 增加 icon 属性,用于在 Card 标题左侧展示图标。
  • 同时给 extra 也包裹一个带 className 的 div 方便控制间距和其他样式。
  • 增加了一个 CSS 变量 --adm-card-header-gap 控制 icon,header,extra 之间的空隙。
  • 单元测试的中文改成英文,让项目更加国际化。

Copy link
Contributor

github-actions bot commented Jul 29, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
./lib/bundle/antd-mobile.es.js 103.12 KB 2.1 s (0%) 1.1 s (+3.78% 🔺) 3.2 s

Copy link
Contributor

PR preview has been successfully built and deployed to https://antd-mobile-preview-pr-6683.surge.sh

Copy link
Contributor

github-actions bot commented Jul 29, 2024

Size Change: +64 B (+0.02%)

Total Size: 357 kB

Filename Size Change
./lib/bundle/antd-mobile.compatible.umd.js 192 kB +31 B (+0.02%)
./lib/bundle/antd-mobile.umd.js 146 kB +23 B (+0.02%)
./lib/bundle/style.css 18 kB +10 B (+0.06%)
ℹ️ View Unchanged
Filename Size
./lib/bundle/css-vars-patch.css 1.42 kB

compressed-size-action

@guoyunhe guoyunhe force-pushed the card-icon branch 2 times, most recently from 5e71b66 to 5dca297 Compare July 29, 2024 06:52
@guoyunhe guoyunhe force-pushed the card-icon branch 2 times, most recently from 4db4ff5 to eb3fefe Compare July 29, 2024 07:12
@zombieJ zombieJ merged commit 7fc3714 into master Jul 29, 2024
10 of 11 checks passed
@zombieJ zombieJ deleted the card-icon branch July 29, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants